T-397: fishing pools doesn't show number of fishes left

.Trove 2 years ago Ticket T-397 Other Messages Raw Message View on Discord

Array
(
    [id] => 1066299949555384391
    [type] => 0
    [content] => 
    [channel_id] => 812354696320647238
    [author] => Array
        (
            [id] => 425403525661458432
            [username] => .Trove
            [avatar] => f1073b841f9444d55989b810d1e9da0f
            [avatar_decoration] => 
            [discriminator] => 6130
            [public_flags] => 0
            [bot] => 1
        )

    [attachments] => Array
        (
        )

    [embeds] => Array
        (
        )

    [mentions] => Array
        (
        )

    [mention_roles] => Array
        (
        )

    [pinned] => 
    [mention_everyone] => 
    [tts] => 
    [timestamp] => 2023-01-21T10:15:18.869000+00:00
    [edited_timestamp] => 
    [flags] => 0
    [components] => Array
        (
        )

)

Issue Details

Platform:PC

Context:

fishing pools' ability to say how many fishes are left doesn't work

Expected:

fishing pools to be able to tell how many fishes are left

Reproduce:

instead of saying how to reproduce (which is just looking at them) I'll say the two ways this bug can be fixed:
-The best one: change the type of value that the game sends to the VFX attribute from float to int
-The cheaty one (pls don't): on the attribute value inside the VFX change it so that it expects float values instead of currently int. I do not recommend this fix as dealing with float in this scenario is inexact and can lead to, for example, instead of marking 1 fish left to mark 0

The bug is due to the VFX not receiving the type of value it expects, and because of it, at least on this scenario, it defaults no matter the value given by the game to the max amount of the VFX attribute which for now is 10 but as pools changed now that we're at it should be raised to 30 to correctly express the total real amount